Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 parsing #85

Merged
merged 3 commits into from
Jun 15, 2024
Merged

IPv6 parsing #85

merged 3 commits into from
Jun 15, 2024

Conversation

mochalins
Copy link
Contributor

@mochalins mochalins commented Jun 15, 2024

Implements IPv6 parsing. More detailed information about parsing spec is in parse function doc comment. Some test cases were added for sanity check, but the tests can be made far more rigorous; as of now, it is a bit inconvenient to test as the actual IPv6 value is a length-16 array of bytes, which is quite tedious to initialize.

Resolves #54

@mochalins
Copy link
Contributor Author

@ikskuh
Unsure of whether scope_id (parsing of which is not supported in this PR, for reasons in doc comment) should be zero-initialized or left undefined. For now it is zero-initialized.

@ikskuh ikskuh merged commit 117d0d5 into ikskuh:master Jun 15, 2024
3 checks passed
@ikskuh
Copy link
Owner

ikskuh commented Jun 15, 2024

Nice work!

@mochalins mochalins deleted the ipv6_parsing branch June 15, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no method for parsing a network.Address.IPv6
2 participants